Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export ersi and algolia result types #401

Merged
merged 2 commits into from
May 17, 2024

Conversation

franciscofsales
Copy link
Collaborator

Added exports to types that are commonly used outside of the lib.

@mtmail
Copy link
Collaborator

mtmail commented Apr 30, 2024

Didn't Algolia Places shut down last year? https://www.algolia.com/blog/product/sunsetting-our-places-feature/

@franciscofsales
Copy link
Collaborator Author

Possibly, I personally am using esri, but noticed algolia types weren't being exported either

@mtmail
Copy link
Collaborator

mtmail commented Apr 30, 2024

I created a PR to remove Algolia #402

@smeijer
Copy link
Owner

smeijer commented May 17, 2024

Thank you!

@smeijer smeijer enabled auto-merge (squash) May 17, 2024 19:08
@smeijer smeijer changed the title Export provider ersi and algolia result types feat: export ersi and algolia result types May 17, 2024
@smeijer smeijer merged commit d3c724b into smeijer:develop May 17, 2024
7 checks passed
@smeijer
Copy link
Owner

smeijer commented May 17, 2024

Thanks again! I've also added you as a collaborator on the project. Please continue to make PRs as you feel the need. You can now make your branches directly on the repo rather than your fork if you want.

Thanks for your contributions! Much appreciated.

@smeijer
Copy link
Owner

smeijer commented May 17, 2024

@all-contributors please add @franciscofsales for code

Copy link
Contributor

@smeijer

I've put up a pull request to add @franciscofsales! 🎉

@smeijer
Copy link
Owner

smeijer commented May 17, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants